Re: [patch 10/12] s390: remove ioctl32 from dasdcmb.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [patch 10/12] s390: remove ioctl32 from dasdcmb.

Martin Schwidefsky
Christoph Hellwig <[hidden email]> wrote on 04/22/2005 09:05:27 PM:

> On Fri, Apr 22, 2005 at 05:02:38PM +0200, Martin Schwidefsky wrote:
> > +#if defined(CONFIG_DASD_CMB) || defined(CONFIG_DASD_CMB_MODULE)
> > +COMPATIBLE_IOCTL(BIODASDCMFENABLE)
> > +COMPATIBLE_IOCTL(BIODASDCMFDISABLE)
> > +COMPATIBLE_IOCTL(BIODASDREADALLCMB)
> > +#endif
>
> I don't think that there should be ifdefs for COMPATIBLE_IOCTL entries.
>

Then it stand to reason to remove ALL the ifdefs in arch/s390/kernel/compat_ioctl.c

blue skies,
   Martin

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Reply | Threaded
Open this post in threaded view
|

Re: [patch 10/12] s390: remove ioctl32 from dasdcmb.

Christoph Hellwig
On Mon, Apr 25, 2005 at 09:42:17AM +0200, Martin Schwidefsky wrote:
> > I don't think that there should be ifdefs for COMPATIBLE_IOCTL entries.
> >
>
> Then it stand to reason to remove ALL the ifdefs in arch/s390/kernel/compat_ioctl.c

makes sense
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/