Re: [2.6 patch] ACPI: add two missing config.h #include's

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [2.6 patch] ACPI: add two missing config.h #include's

Brown, Len
Applied.

thanks,
-Len

On Sun, 2005-04-17 at 14:19, Adrian Bunk wrote:

> On Sat, Apr 16, 2005 at 08:59:23AM +0100, Russell King wrote:
> > On Sat, Apr 16, 2005 at 04:38:52AM +0200, Adrian Bunk wrote:
> > > In the Linux kernel, it's more common to put such header
> dependencies
> > > for header files into the C files, but if the ACPI people agree a
> patch
> > > to add the #include <linux/config.h> to acpi_bus.h is the other
> possble
> > > correct solution for this issue.
> >
> > With the exception of linux/config.h.
> >
> > Do a 'make configcheck' and it'll tell you where linux/config.h is
> missing
> > and where it shouldn't be.
>
> OK, then the patch below is the correct solution.
>
> cu
> Adrian
>
>
> <--  snip  -->
>
>
> This patch fixes the following warning by adding two missing config.h
> #include's:
>
> <--  snip  -->
>
> ...
>   CC      drivers/serial/8250_acpi.o
> drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
> drivers/serial/8250_acpi.c:51: warning: implicit declaration of
> function
> `acpi_register_gsi'
> ...
>
> <--  snip  -->
>
> Signed-off-by: Adrian Bunk <[hidden email]>
>
> --- linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h.old      
> 2005-04-17 19:05:23.000000000 +0200
> +++ linux-2.6.12-rc2-mm3-full/include/acpi/acpi_bus.h   2005-04-17
> 19:05:37.000000000 +0200
> @@ -26,6 +26,7 @@
>  #ifndef __ACPI_BUS_H__
>  #define __ACPI_BUS_H__
>
> +#include <linux/config.h>
>  #include <linux/kobject.h>
>
>  #include <acpi/acpi.h>
> --- linux-2.6.12-rc2-mm3-full/include/linux/acpi.h.old  2005-04-17
> 19:25:51.000000000 +0200
> +++ linux-2.6.12-rc2-mm3-full/include/linux/acpi.h      2005-04-17
> 19:24:54.000000000 +0200
> @@ -25,6 +25,8 @@
>  #ifndef _LINUX_ACPI_H
>  #define _LINUX_ACPI_H
>
> +#include <linux/config.h>
> +
>  #ifdef CONFIG_ACPI
>
>  #ifndef _LINUX
>
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/