Re: 2.6.12-rc3 fails to read partition table

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: 2.6.12-rc3 fails to read partition table

Hubert Tonneau
Hubert Tonneau wrote:
>
> 2.6.11 and 2.6.11.7 work fine.
> 2.6.12-rc1 2.6.12-rc2 and 2.6.12-rc3 fail to read partiton table on my laptop,
> also 2.6.12-rc3 works fine on another box also running FullPliant.

I tracked down the trouble to the following patch.
Partitions with type 0 are now ignored, and my hda1 single partition has been
unwisely set so.
The question might be: is it a good idea to introduce that extra constrain
in the middle of a stable serie ?

diff -urN linux-2.6.11/fs/partitions/msdos.c linux-2.6.12-rc3/fs/partitions/msdos.c
--- linux-2.6.11/fs/partitions/msdos.c 2005-03-01 23:38:12.000000000 -0800
+++ linux-2.6.12-rc3/fs/partitions/msdos.c 2005-04-20 17:03:15.000000000 -0700
@@ -114,6 +114,9 @@
  */
  for (i=0; i<4; i++, p++) {
  u32 offs, size, next;
+
+ if (SYS_IND(p) == 0)
+ continue;
  if (!NR_SECTS(p) || is_extended_partition(p))
  continue;
 
@@ -430,6 +433,8 @@
  for (slot = 1 ; slot <= 4 ; slot++, p++) {
  u32 start = START_SECT(p)*sector_size;
  u32 size = NR_SECTS(p)*sector_size;
+ if (SYS_IND(p) == 0)
+ continue;
  if (!size)
  continue;
  if (is_extended_partition(p)) {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Reply | Threaded
Open this post in threaded view
|

Re: 2.6.12-rc3 fails to read partition table

7eggert (Bugzilla)
Hubert Tonneau <[hidden email]> wrote:
> Hubert Tonneau wrote:

>> 2.6.11 and 2.6.11.7 work fine.
>> 2.6.12-rc1 2.6.12-rc2 and 2.6.12-rc3 fail to read partiton table on my
>> laptop, also 2.6.12-rc3 works fine on another box also running FullPliant.
>
> I tracked down the trouble to the following patch.
> Partitions with type 0 are now ignored, and my hda1 single partition has been
> unwisely set so.
> The question might be: is it a good idea to introduce that extra constrain
> in the middle of a stable serie ?

It is needed to work around other problems. Partition type 0 is usurally
considered to be empty, and some systems depend on that behaviour.
--
"If you see a bomb technician running, follow him."
-U.S.A.F. Ammo Tech Sgt

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [hidden email]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/