[PATCH v3] i2c: at91: change log when dma configuration fails

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH v3] i2c: at91: change log when dma configuration fails

Ludovic Desroches
When the DMA configuration fails, there is a log reporting that we can't
use DMA and indicating the error number. When booting the kernel, it is
annoying to see this error number. Moreover, people can think something
is going wrong. It is not the case, it means that DMA can't be used but
it doesn't prevent to use i2c.

Signed-off-by: Ludovic Desroches <[hidden email]>
---
 drivers/i2c/busses/i2c-at91.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Douglas, sorry but I can't answer you directly, your email address is
blacklisted on our server.

Changes:
- v3:
  - s/request/get (comment done in private)
- v2:
  - remove ret parameter

diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
index 921d32b..f233726 100644
--- a/drivers/i2c/busses/i2c-at91.c
+++ b/drivers/i2c/busses/i2c-at91.c
@@ -1013,7 +1013,7 @@ static int at91_twi_configure_dma(struct at91_twi_dev *dev, u32 phy_addr)
 
 error:
  if (ret != -EPROBE_DEFER)
- dev_info(dev->dev, "can't use DMA, error %d\n", ret);
+ dev_info(dev->dev, "can't get DMA channel, continue without DMA support\n");
  if (dma->chan_rx)
  dma_release_channel(dma->chan_rx);
  if (dma->chan_tx)
--
2.5.0

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH v3] i2c: at91: change log when dma configuration fails

Wolfram Sang-2
On Fri, May 20, 2016 at 02:06:31PM +0200, Ludovic Desroches wrote:
> When the DMA configuration fails, there is a log reporting that we can't
> use DMA and indicating the error number. When booting the kernel, it is
> annoying to see this error number. Moreover, people can think something
> is going wrong. It is not the case, it means that DMA can't be used but
> it doesn't prevent to use i2c.
>
> Signed-off-by: Ludovic Desroches <[hidden email]>

Applied to for-next, thanks!


signature.asc (836 bytes) Download Attachment
Loading...