[PATCH] target: Drop incorrect ABORT_TASK put for completed commands

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[PATCH] target: Drop incorrect ABORT_TASK put for completed commands

Nicholas A. Bellinger-3
From: Nicholas Bellinger <[hidden email]>

This patch fixes a recent ABORT_TASK regression associated
with commit febe562c, where a left-over target_put_sess_cmd()
would still be called when __target_check_io_state() detected
a command has already been completed, and explicit ABORT must
be avoided.

Note commit febe562c dropped the local kref_get_unless_zero()
check in core_tmr_abort_task(), but did not drop this extra
corresponding target_put_sess_cmd() in the failure path.

So go ahead and drop this now bogus target_put_sess_cmd(),
and avoid this potential use-after-free.

Reported-by: Dan Lane <[hidden email]>
Cc: Quinn Tran <[hidden email]>
Cc: Himanshu Madhani <[hidden email]>
Cc: Sagi Grimberg <[hidden email]>
Cc: Christoph Hellwig <[hidden email]>
Cc: Hannes Reinecke <[hidden email]>
Cc: Andy Grover <[hidden email]>
Cc: Mike Christie <[hidden email]>
Signed-off-by: Nicholas Bellinger <[hidden email]>
 drivers/target/target_core_tmr.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/target/target_core_tmr.c b/drivers/target/target_core_tmr.c
index 82a663b..4f229e7 100644
--- a/drivers/target/target_core_tmr.c
+++ b/drivers/target/target_core_tmr.c
@@ -177,7 +177,6 @@ void core_tmr_abort_task(
  if (!__target_check_io_state(se_cmd, se_sess, 0)) {
  spin_unlock_irqrestore(&se_sess->sess_cmd_lock, flags);
- target_put_sess_cmd(se_cmd);
  goto out;