[PATCH] nvme/host: Add missing blk_integrity tag_size + flags assignments

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] nvme/host: Add missing blk_integrity tag_size + flags assignments

Nicholas A. Bellinger-3
From: Nicholas Bellinger <[hidden email]>

While doing recent bring-up of nvme/host with target-core T10-PI,
I noticed /sys/block/nvme*/integrity/device_is_integrity_capable
was false, and /sys/block/nvme*/integrity/tag_size contained
a bogus value.

AFAICT outside of blk_integrity_compare() for DM + MD these
are informational values, but go ahead and add the missing
assignments for nvme/host to match what SCSI does within
sd_dif_config_host() for consistency's sake.

Cc: Keith Busch <[hidden email]>
Cc: Jay Freyensee <[hidden email]>
Cc: Martin K. Petersen <[hidden email]>
Cc: Sagi Grimberg <[hidden email]>
Cc: Christoph Hellwig <[hidden email]>
Cc: Jens Axboe <[hidden email]>
Signed-off-by: Nicholas Bellinger <[hidden email]>
---
 drivers/nvme/host/core.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index b8e22fe..cbd08f8 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -674,10 +674,14 @@ static void nvme_init_integrity(struct nvme_ns *ns)
  switch (ns->pi_type) {
  case NVME_NS_DPS_PI_TYPE3:
  integrity.profile = &t10_pi_type3_crc;
+ integrity.tag_size = sizeof(u16) + sizeof(u32);
+ integrity.flags |= BLK_INTEGRITY_DEVICE_CAPABLE;
  break;
  case NVME_NS_DPS_PI_TYPE1:
  case NVME_NS_DPS_PI_TYPE2:
  integrity.profile = &t10_pi_type1_crc;
+ integrity.tag_size = sizeof(u16);
+ integrity.flags |= BLK_INTEGRITY_DEVICE_CAPABLE;
  break;
  default:
  integrity.profile = NULL;
--
1.9.1

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] nvme/host: Add missing blk_integrity tag_size + flags assignments

Sagi Grimberg-3
Looks fine,

Reviewed-by: Sagi Grimberg <[hidden email]>
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] nvme/host: Add missing blk_integrity tag_size + flags assignments

Christoph Hellwig-2
In reply to this post by Nicholas A. Bellinger-3
Does NVMe really force ATO=1?  Sorry, didn't have much time to spend
with that part of the spec.
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] nvme/host: Add missing blk_integrity tag_size + flags assignments

Martin K. Petersen-3
>>>>> "Christoph" == Christoph Hellwig <[hidden email]> writes:

Christoph> Does NVMe really force ATO=1?

It does.

--
Martin K. Petersen Oracle Linux Engineering
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] nvme/host: Add missing blk_integrity tag_size + flags assignments

Martin K. Petersen-3
In reply to this post by Nicholas A. Bellinger-3
>>>>> "Nicholas" == Nicholas A Bellinger <[hidden email]> writes:

Nicholas> While doing recent bring-up of nvme/host with target-core
Nicholas> T10-PI, I noticed
Nicholas> /sys/block/nvme*/integrity/device_is_integrity_capable was
Nicholas> false, and /sys/block/nvme*/integrity/tag_size contained a
Nicholas> bogus value.

Reviewed-by: Martin K. Petersen <[hidden email]>

--
Martin K. Petersen Oracle Linux Engineering