Quantcast

[PATCH] fs: ubifs: Replace kmem_cache_alloc/memset with kmem_cache_zalloc

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] fs: ubifs: Replace kmem_cache_alloc/memset with kmem_cache_zalloc

Salah Triki
Use kmem_cache_zalloc instead of kmem_cache_alloc/memset.

Signed-off-by: Salah Triki <[hidden email]>
---
 fs/ubifs/super.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 7034995..f509200 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -262,12 +262,10 @@ static struct inode *ubifs_alloc_inode(struct super_block *sb)
 {
  struct ubifs_inode *ui;
 
- ui = kmem_cache_alloc(ubifs_inode_slab, GFP_NOFS);
+ ui = kmem_cache_zalloc(ubifs_inode_slab, GFP_NOFS);
  if (!ui)
  return NULL;
 
- memset((void *)ui + sizeof(struct inode), 0,
-       sizeof(struct ubifs_inode) - sizeof(struct inode));
  mutex_init(&ui->ui_mutex);
  spin_lock_init(&ui->ui_lock);
  return &ui->vfs_inode;
--
1.9.1

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PATCH] fs: ubifs: Replace kmem_cache_alloc/memset with kmem_cache_zalloc

Richard Weinberger
Am 26.05.2016 um 00:04 schrieb Salah Triki:

> Use kmem_cache_zalloc instead of kmem_cache_alloc/memset.
>
> Signed-off-by: Salah Triki <[hidden email]>
> ---
>  fs/ubifs/super.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index 7034995..f509200 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -262,12 +262,10 @@ static struct inode *ubifs_alloc_inode(struct super_block *sb)
>  {
>   struct ubifs_inode *ui;
>  
> - ui = kmem_cache_alloc(ubifs_inode_slab, GFP_NOFS);
> + ui = kmem_cache_zalloc(ubifs_inode_slab, GFP_NOFS);
>   if (!ui)
>   return NULL;
>  
> - memset((void *)ui + sizeof(struct inode), 0,
> -       sizeof(struct ubifs_inode) - sizeof(struct inode));

Your patch fails to explain why it is needed.
Also note that the path slightly changes the semantics.

Thanks,
//richard
Loading...