[PATCH] fbtft: limit transfer length by spi device limit

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] fbtft: limit transfer length by spi device limit

Michal Suchanek
Some SPI controllers can transfer only small piece of data at a time.
Since SPI core gained a function to get the maximum transfer length use
it.

Signed-off-by: Michal Suchanek <[hidden email]>
---

 Tested on sunxi spi with DMA enabled and disabled. Makes a visible speed
difference and display works in either case.

 drivers/staging/fbtft/fbtft-core.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 0c1a77c..f3bdc8f 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -1346,6 +1346,15 @@ int fbtft_probe_common(struct fbtft_display *display,
  return PTR_ERR(pdata);
  }
 
+ if (sdev && (spi_max_transfer_size(sdev) < SIZE_MAX))
+ if ((pdata->txbuflen <= 0) || (pdata->txbuflen > spi_max_transfer_size(sdev))) {
+ dev_warn(dev,
+ "Limiting used buffer size %i -> %i due to device %s transfer size limitation",
+ pdata->txbuflen, spi_max_transfer_size(sdev),
+ dev_name(&sdev->dev));
+ pdata->txbuflen = spi_max_transfer_size(sdev);
+ }
+
  info = fbtft_framebuffer_alloc(display, dev, pdata);
  if (!info)
  return -ENOMEM;
--
2.8.1