[PATCH 4.4 00/74] 4.4.5-stable review

classic Classic list List threaded Threaded
86 messages Options
12345
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 4.4 34/74] arm64: vmemmap: use virtual projection of linear region

Greg KH-4
On Sat, Mar 12, 2016 at 08:51:26AM +0700, Ard Biesheuvel wrote:

> On 8 March 2016 at 20:45, Ard Biesheuvel <[hidden email]> wrote:
> > On 8 March 2016 at 20:44, Greg Kroah-Hartman <[hidden email]> wrote:
> >> On Tue, Mar 08, 2016 at 05:40:14PM +0700, Ard Biesheuvel wrote:
> >>> On 8 March 2016 at 07:02, Greg Kroah-Hartman <[hidden email]> wrote:
> >>> > 4.4-stable review patch.  If anyone has any objections, please let me know.
> >>> >
> >>>
> >>> Please hold off on this one. We are seeing some breakage on 64k pages systems
> >>
> >> If this problem is also in Linus's tree, I'd like to keep it in to keep
> >> things "bug compatible".  Please let me know what fix that I should
> >> apply to resolve this.
> >>
> >
> > I am about to send out the patch that should fix this, so I will put you on cc.
> >
>
> Not sure what happened here, but this patch is in 4.4-stable now, but
> the fix is not.

Because the fix came out _after_ I released that kernel?  I can't go
back in time...

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 4.4 34/74] arm64: vmemmap: use virtual projection of linear region

Ard Biesheuvel


> On 12 mrt. 2016, at 13:50, Greg Kroah-Hartman <[hidden email]> wrote:
>
>> On Sat, Mar 12, 2016 at 08:51:26AM +0700, Ard Biesheuvel wrote:
>>> On 8 March 2016 at 20:45, Ard Biesheuvel <[hidden email]> wrote:
>>>> On 8 March 2016 at 20:44, Greg Kroah-Hartman <[hidden email]> wrote:
>>>>> On Tue, Mar 08, 2016 at 05:40:14PM +0700, Ard Biesheuvel wrote:
>>>>>> On 8 March 2016 at 07:02, Greg Kroah-Hartman <[hidden email]> wrote:
>>>>>> 4.4-stable review patch.  If anyone has any objections, please let me know.
>>>>>
>>>>> Please hold off on this one. We are seeing some breakage on 64k pages systems
>>>>
>>>> If this problem is also in Linus's tree, I'd like to keep it in to keep
>>>> things "bug compatible".  Please let me know what fix that I should
>>>> apply to resolve this.
>>>
>>> I am about to send out the patch that should fix this, so I will put you on cc.
>>
>> Not sure what happened here, but this patch is in 4.4-stable now, but
>> the fix is not.
>
> Because the fix came out _after_ I released that kernel?  I can't go
> back in time...
>

I kind of got the whole chronology thing. I am just surprised you pulled only that patch (and not the fix) anyway, since you knew it would break things, and that a fix was on the way.
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 4.4 34/74] arm64: vmemmap: use virtual projection of linear region

Greg KH-4
On Sat, Mar 12, 2016 at 01:55:44PM +0800, Ard Biesheuvel wrote:

>
>
> > On 12 mrt. 2016, at 13:50, Greg Kroah-Hartman <[hidden email]> wrote:
> >
> >> On Sat, Mar 12, 2016 at 08:51:26AM +0700, Ard Biesheuvel wrote:
> >>> On 8 March 2016 at 20:45, Ard Biesheuvel <[hidden email]> wrote:
> >>>> On 8 March 2016 at 20:44, Greg Kroah-Hartman <[hidden email]> wrote:
> >>>>> On Tue, Mar 08, 2016 at 05:40:14PM +0700, Ard Biesheuvel wrote:
> >>>>>> On 8 March 2016 at 07:02, Greg Kroah-Hartman <[hidden email]> wrote:
> >>>>>> 4.4-stable review patch.  If anyone has any objections, please let me know.
> >>>>>
> >>>>> Please hold off on this one. We are seeing some breakage on 64k pages systems
> >>>>
> >>>> If this problem is also in Linus's tree, I'd like to keep it in to keep
> >>>> things "bug compatible".  Please let me know what fix that I should
> >>>> apply to resolve this.
> >>>
> >>> I am about to send out the patch that should fix this, so I will put you on cc.
> >>
> >> Not sure what happened here, but this patch is in 4.4-stable now, but
> >> the fix is not.
> >
> > Because the fix came out _after_ I released that kernel?  I can't go
> > back in time...
> >
>
> I kind of got the whole chronology thing. I am just surprised you
> pulled only that patch (and not the fix) anyway, since you knew it
> would break things, and that a fix was on the way.

That way I knew you all would work quickly to get the fix in :)

We do this all the time, nothing new here, being "bug compatible" is
good...

thanks,

greg k-h
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 4.4 34/74] arm64: vmemmap: use virtual projection of linear region

Ard Biesheuvel


> On 12 mrt. 2016, at 14:05, Greg Kroah-Hartman <[hidden email]> wrote:
>
>> On Sat, Mar 12, 2016 at 01:55:44PM +0800, Ard Biesheuvel wrote:
>>
>>
>>>> On 12 mrt. 2016, at 13:50, Greg Kroah-Hartman <[hidden email]> wrote:
>>>>
>>>>> On Sat, Mar 12, 2016 at 08:51:26AM +0700, Ard Biesheuvel wrote:
>>>>>> On 8 March 2016 at 20:45, Ard Biesheuvel <[hidden email]> wrote:
>>>>>>> On 8 March 2016 at 20:44, Greg Kroah-Hartman <[hidden email]> wrote:
>>>>>>>> On Tue, Mar 08, 2016 at 05:40:14PM +0700, Ard Biesheuvel wrote:
>>>>>>>> On 8 March 2016 at 07:02, Greg Kroah-Hartman <[hidden email]> wrote:
>>>>>>>> 4.4-stable review patch.  If anyone has any objections, please let me know.
>>>>>>>
>>>>>>> Please hold off on this one. We are seeing some breakage on 64k pages systems
>>>>>>
>>>>>> If this problem is also in Linus's tree, I'd like to keep it in to keep
>>>>>> things "bug compatible".  Please let me know what fix that I should
>>>>>> apply to resolve this.
>>>>>
>>>>> I am about to send out the patch that should fix this, so I will put you on cc.
>>>>
>>>> Not sure what happened here, but this patch is in 4.4-stable now, but
>>>> the fix is not.
>>>
>>> Because the fix came out _after_ I released that kernel?  I can't go
>>> back in time...
>>
>> I kind of got the whole chronology thing. I am just surprised you
>> pulled only that patch (and not the fix) anyway, since you knew it
>> would break things, and that a fix was on the way.
>
> That way I knew you all would work quickly to get the fix in :)
>
> We do this all the time, nothing new here, being "bug compatible" is
> good...
>

Do you get many requests from stable tree users for this bug compatibility with mainline?


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 4.4 00/74] 4.4.5-stable review

Greg KH-4
In reply to this post by Sedat Dilek-2
On Tue, Mar 08, 2016 at 05:15:13PM +0100, Sedat Dilek wrote:

> On Tue, Mar 8, 2016 at 2:39 PM, Greg Kroah-Hartman
> <[hidden email]> wrote:
> > On Tue, Mar 08, 2016 at 10:12:13AM +0100, Sedat Dilek wrote:
> >> Hi Greg,
> >>
> >> I tested with my usual setup/config.
> >>
> >> Looks good so far.
> >>
> >> Missing some net-ppp-fixes / overlayfs-fixes / userfaultfd-fixes, but
> >> I guess you will pick them up in a 6th run of Linux v4.4.y.
> >
> > I have no idea what these "fixes" are you speak of, my queue is empty,
> > there are no known stable patches I haven't applied yet.  What exactly
> > are you referring to here?
> >
> > thansk,
> >
> >
>
> Here we go...
>
> [1] "userfaultfd: don't block on the last VM updates at exit time"
>
> [2] "ppp: release rtnl mutex when interface creation fails"
>
> ( I was involved in... Fixes: 58a89ecaca53 ("ppp: fix lockdep splat in
> ppp_dev_uninit()" )
>
> [3] "ovl: fix working on distributed fs as lower layer"
>
> BTW, in [1] Linus forgot to add a "CC:stable", how is this handled
> when a maintainer forgets this?

Someone needs to tell me.  I've grabbed it now, the networking one will
come through David, and the ovl patch is already in my tree for this
round of releases.  I couldn't take it before as it wasn't in Linus's
tree.

thanks,

greg k-h
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 4.4 00/74] 4.4.5-stable review

Sedat Dilek-2
On Sun, Mar 13, 2016 at 4:45 AM, Greg Kroah-Hartman
<[hidden email]> wrote:

> On Tue, Mar 08, 2016 at 05:15:13PM +0100, Sedat Dilek wrote:
>> On Tue, Mar 8, 2016 at 2:39 PM, Greg Kroah-Hartman
>> <[hidden email]> wrote:
>> > On Tue, Mar 08, 2016 at 10:12:13AM +0100, Sedat Dilek wrote:
>> >> Hi Greg,
>> >>
>> >> I tested with my usual setup/config.
>> >>
>> >> Looks good so far.
>> >>
>> >> Missing some net-ppp-fixes / overlayfs-fixes / userfaultfd-fixes, but
>> >> I guess you will pick them up in a 6th run of Linux v4.4.y.
>> >
>> > I have no idea what these "fixes" are you speak of, my queue is empty,
>> > there are no known stable patches I haven't applied yet.  What exactly
>> > are you referring to here?
>> >
>> > thansk,
>> >
>> >
>>
>> Here we go...
>>
>> [1] "userfaultfd: don't block on the last VM updates at exit time"
>>
>> [2] "ppp: release rtnl mutex when interface creation fails"
>>
>> ( I was involved in... Fixes: 58a89ecaca53 ("ppp: fix lockdep splat in
>> ppp_dev_uninit()" )
>>
>> [3] "ovl: fix working on distributed fs as lower layer"
>>
>> BTW, in [1] Linus forgot to add a "CC:stable", how is this handled
>> when a maintainer forgets this?
>
> Someone needs to tell me.  I've grabbed it now, the networking one will
> come through David, and the ovl patch is already in my tree for this
> round of releases.  I couldn't take it before as it wasn't in Linus's
> tree.
>
> thanks,
>

Thanks for the feedback!

- Sedat -
12345